New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean DOD Certs #1578

Merged
merged 2 commits into from Jan 16, 2019

Conversation

2 participants
@pjdufour-truss
Copy link
Contributor

pjdufour-truss commented Jan 10, 2019

Description

This PR makes an update to the initDODCertificates function, so that it cleans the values from move-mil-dod-tls-cert and move-mil-dod-ca-cert, which should functionally allow us to append the move.mil certificate and the intermediate certificate together, even when they may have arbitrary comments around each block, e.g., issuer. Acceptance tests should pull the certs down from chamber properly now, too!

Reviewer Notes

Is there anything you would like reviewers to give additional scrutiny?

Try running the acceptance test with:

TEST_ACC_ENV=staging TEST_ACC_DOD_CERTIFICATES=1 make webserver_test

Setup

None

Code Review Verification Steps

  • Code follows the guidelines for Logging
  • The requirements listed in
    Querying the Database Safely
    have been satisfied.
  • Any new migrations/schema changes:
    • Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
    • Have been communicated to #dp3-engineering
    • Secure migrations have been tested using bin/run-prod-migrations
  • There are no aXe warnings for UI.
  • This works in IE.
  • Any new client dependencies (Google Analytics, hosted libraries, CDNs, etc) have been:
  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

Screenshots

N.A.

@pjdufour-truss pjdufour-truss changed the title Trim DOD Certs Clean DOD Certs Jan 15, 2019

@pjdufour-truss pjdufour-truss force-pushed the better_cert_checks branch from 624c7e6 to 524cc39 Jan 15, 2019

@pjdufour-truss pjdufour-truss force-pushed the better_cert_checks branch from 524cc39 to fa6cddb Jan 15, 2019

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

🚀 - I had two clarifying questions but I think this is good to go.

@pjdufour-truss pjdufour-truss merged commit 4266274 into master Jan 16, 2019

12 checks passed

ci/circleci: acceptance_tests Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details

@pjdufour-truss pjdufour-truss deleted the better_cert_checks branch Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment