New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Cypress command for selecting a move locator #1694

Merged
merged 2 commits into from Feb 4, 2019

Conversation

2 participants
@stangah
Copy link
Contributor

stangah commented Feb 2, 2019

Description

We started getting flaky failures recently around e2e tests that loaded either a TSP or office queue. Turns out our queues use a ReactTable, which implements its own loading UI that we make use of. We have some Cypress workarounds for the loading screen we invented, but not this ReactTable one. So this PR creates an abstraction around selecting a move by moveLocator and adds a check that the table's loading UI is gone

@stangah stangah requested review from akostibas , Ryan-Koch and chrisgilmerproj Feb 2, 2019

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

🌟 Awesome! Thanks for taking this one on.

@stangah stangah merged commit 39b49d7 into master Feb 4, 2019

14 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details

@stangah stangah deleted the ps-tsp-doc-e2e branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment