New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callgraph functions #1706

Merged
merged 1 commit into from Feb 7, 2019

Conversation

2 participants
@pjdufour-truss
Copy link
Contributor

pjdufour-truss commented Feb 6, 2019

Description

This PR adds a pre-commit hook and two new scripts to bin that use callgraph to report information on which packages and functions are actually used by the webserver. Whenever some does a PR, the docs/packages.txt file will change if any packages are removed or added.

Reviewer Notes

Is there anything you would like reviewers to give additional scrutiny?

Setup

Add any steps or code to run in this section to help others prepare to run your code:

pre-commit run dump-packages -a

Code Review Verification Steps

  • Code follows the guidelines for Logging
  • The requirements listed in
    Querying the Database Safely
    have been satisfied.
  • Any new migrations/schema changes:
    • Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
    • Have been communicated to #dp3-engineering
    • Secure migrations have been tested using bin/run-prod-migrations
  • There are no aXe warnings for UI.
  • This works in IE.
  • Any new client dependencies (Google Analytics, hosted libraries, CDNs, etc) have been:
  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

Screenshots

N.A.

@pjdufour-truss pjdufour-truss requested a review from chrisgilmerproj Feb 6, 2019

@pjdufour-truss pjdufour-truss changed the title WIP / Callgraph functions Callgraph functions Feb 6, 2019

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

💯

@pjdufour-truss pjdufour-truss force-pushed the callgraph branch 3 times, most recently from 91df7cf to 975452a Feb 6, 2019

@pjdufour-truss pjdufour-truss force-pushed the callgraph branch from 975452a to bb24df0 Feb 7, 2019

@pjdufour-truss pjdufour-truss merged commit 7235d9d into master Feb 7, 2019

15 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details

@pjdufour-truss pjdufour-truss deleted the callgraph branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment