New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waits for ReactTable on app login for office, tsp #1707

Merged
merged 1 commit into from Feb 6, 2019

Conversation

2 participants
@stangah
Copy link
Contributor

stangah commented Feb 6, 2019

Description

More flaky e2e-ness around ReactTable loading. This time it spawned from just running signIntoTSP and trying to load the default queue page. This PR pulls out waitForReactTableLoad to be its own thing and calls in signIntoOffice and signIntoTSP.

It seems we've hit some critical slowness around loading ReactTable, so I expect we'll need to start putting waitForReactTableLoad in other places soon, too.

@stangah stangah requested review from chrisgilmerproj and akostibas Feb 6, 2019

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

🌟

@stangah stangah merged commit 3f4488c into master Feb 6, 2019

15 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details

@stangah stangah deleted the ps-e2e-table-fix branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment