New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs/packages.txt #1713

Merged
merged 2 commits into from Feb 7, 2019

Conversation

2 participants
@pjdufour-truss
Copy link
Contributor

pjdufour-truss commented Feb 7, 2019

Description

Removes docs/packages.txt and the pre-commit hook. Since we don't require rebasing before merges into master, our approach wasn't going to work and we need to rethink.

Reviewer Notes

Is there anything you would like reviewers to give additional scrutiny?

Setup

Add any steps or code to run in this section to help others prepare to run your code:

echo "Code goes here"

Code Review Verification Steps

  • Code follows the guidelines for Logging
  • The requirements listed in
    Querying the Database Safely
    have been satisfied.
  • Any new migrations/schema changes:
    • Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
    • Have been communicated to #dp3-engineering
    • Secure migrations have been tested using bin/run-prod-migrations
  • There are no aXe warnings for UI.
  • This works in IE.
  • Any new client dependencies (Google Analytics, hosted libraries, CDNs, etc) have been:
  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

Screenshots

N.A.

@pjdufour-truss pjdufour-truss requested a review from chrisgilmerproj Feb 7, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #1713 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1713   +/-   ##
=======================================
  Coverage   47.17%   47.17%           
=======================================
  Files         410      410           
  Lines       17183    17183           
  Branches     1603     1603           
=======================================
  Hits         8106     8106           
  Misses       8356     8356           
  Partials      721      721
Flag Coverage Δ
#go 56.86% <ø> (ø) ⬆️
#javascript 32.67% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7235d9d...223c57b. Read the comment docs.

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

Go ahead and merge. I wouldn't have thought of this!

@pjdufour-truss pjdufour-truss merged commit 58502a3 into master Feb 7, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: client_test_coverage Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 7235d9d...223c57b
Details
codecov/project 47.17% remains the same compared to 7235d9d
Details

@pjdufour-truss pjdufour-truss deleted the fix_docs branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment