Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate README for Go installation #1717
Conversation
akostibas
requested review from
chrisgilmerproj
,
Igarfinkle
and
mikena-truss
Feb 8, 2019
akostibas
force-pushed the
ak-update-docs
branch
from
5756c09
to
7ecdcfc
Feb 8, 2019
mikena-truss
approved these changes
Feb 8, 2019
This comment has been minimized.
This comment has been minimized.
Thanks! |
chrisgilmerproj
reviewed
Feb 8, 2019
* We tend to use the latest version of Go. | ||
* Install it with Homebrew: `brew install go` | ||
* Pin it, so that you don't accidentally upgrade before we upgrade the project: `brew pin go` | ||
* When we upgrade the project's go version, unpin, upgrade, and then re-pin: `brew unpin go; brew upgrade go; brew pin go` |
This comment has been minimized.
This comment has been minimized.
chrisgilmerproj
Feb 8, 2019
Contributor
This is a much better way to handle this. I didn't even know about brew pin
and brew unpin
!
I might still suggest that you mention to people that previously set their $PATH
that it be either removed or changed to export PATH="/usr/local/opt/go/bin:$PATH"
.
chrisgilmerproj
approved these changes
Feb 8, 2019
|
akostibas
merged commit 2c8a32d
into
master
Feb 8, 2019
15 checks passed
Codacy/PR Quality Review
Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental
Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local
Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging
Your tests passed on CircleCI!
Details
ci/circleci: build_app
Your tests passed on CircleCI!
Details
ci/circleci: build_migrations
Your tests passed on CircleCI!
Details
ci/circleci: build_tools
Your tests passed on CircleCI!
Details
ci/circleci: client_test
Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove
Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office
Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp
Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang
Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn
Your tests passed on CircleCI!
Details
ci/circleci: pre_test
Your tests passed on CircleCI!
Details
ci/circleci: server_test
Your tests passed on CircleCI!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
akostibas commentedFeb 8, 2019
•
edited
Description
Updating the README to be in line with how installing Go from brew works.
Brew seems to have removed the ability to install specific go versions:
Thus, the best we can do right now is install the latest version and pin it.
[EDIT: actually, the only versions it provides are minor versions, such as
go@1.9
,go@1.8
, etc. Which leaves us in the same place.]I did look into using🔥 .
goenv
(https://github.com/syndbg/goenv) which seems like a nice alternative. However, the version of goenv in brew doesn't support installing go1.11.5... so,