New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for Go installation #1717

Merged
merged 3 commits into from Feb 8, 2019

Conversation

3 participants
@akostibas
Copy link
Contributor

akostibas commented Feb 8, 2019

Description

Updating the README to be in line with how installing Go from brew works.

Brew seems to have removed the ability to install specific go versions:

$ brew install go@1.11.5
Error: No available formula with the name "go@1.11.5" 
==> Searching for a previously deleted formula (in the last month)...
Warning: homebrew/core is shallow clone. To get complete history run:
  git -C "$(brew --repo homebrew/core)" fetch --unshallow

Error: No previously deleted formula found.
==> Searching for similarly named formulae...
Error: No similarly named formulae found.
==> Searching taps...
==> Searching taps on GitHub...
Error: No formulae found in taps.

Thus, the best we can do right now is install the latest version and pin it.
[EDIT: actually, the only versions it provides are minor versions, such as go@1.9, go@1.8, etc. Which leaves us in the same place.]

I did look into using goenv (https://github.com/syndbg/goenv) which seems like a nice alternative. However, the version of goenv in brew doesn't support installing go1.11.5... so, 馃敟.

@akostibas akostibas force-pushed the ak-update-docs branch from 5756c09 to 7ecdcfc Feb 8, 2019

@mikena-truss

This comment has been minimized.

Copy link
Contributor

mikena-truss commented Feb 8, 2019

Thanks!

* We tend to use the latest version of Go.
* Install it with Homebrew: `brew install go`
* Pin it, so that you don't accidentally upgrade before we upgrade the project: `brew pin go`
* When we upgrade the project's go version, unpin, upgrade, and then re-pin: `brew unpin go; brew upgrade go; brew pin go`

This comment has been minimized.

@chrisgilmerproj

chrisgilmerproj Feb 8, 2019

Contributor

This is a much better way to handle this. I didn't even know about brew pin and brew unpin!

I might still suggest that you mention to people that previously set their $PATH that it be either removed or changed to export PATH="/usr/local/opt/go/bin:$PATH".

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

馃憤

@akostibas akostibas merged commit 2c8a32d into master Feb 8, 2019

15 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment