Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go to version 1.12 #1808

Merged
merged 2 commits into from Mar 1, 2019

Conversation

2 participants
@Ronolibert
Copy link
Contributor

Ronolibert commented Mar 1, 2019

Description

Update our Go version to the latest version

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

🚀

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #1808 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1808      +/-   ##
==========================================
- Coverage   49.07%   48.82%   -0.26%     
==========================================
  Files         422      423       +1     
  Lines       18087    18011      -76     
  Branches     1621     1624       +3     
==========================================
- Hits         8877     8793      -84     
- Misses       8432     8439       +7     
- Partials      778      779       +1
@@ -93,7 +93,7 @@ repos:
- repo: git://github.com/dnephin/pre-commit-golang
rev: v0.3.2
hooks:
- id: go-vet
# - id: go-vet uncomment when go@1.12 is supported for this hook

This comment has been minimized.

@chrisgilmerproj

This comment has been minimized.

@Ronolibert

Ronolibert Mar 1, 2019

Author Contributor

Card now made to update the version of pre-commit-golang when this fixed is released!

@Ronolibert Ronolibert merged commit 38462bd into master Mar 1, 2019

18 of 19 checks passed

codecov/project 48.82% (-0.26%) compared to f6d1f63
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: client_test_coverage Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing f6d1f63...907125e
Details

@Ronolibert Ronolibert deleted the roc-upgrade-go-1.12 branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.