Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict access to dps_auth_cookie_url #1811

Merged
merged 2 commits into from Mar 4, 2019

Conversation

2 participants
@aileendds
Copy link
Contributor

aileendds commented Mar 4, 2019

Preventing everyone except whitelisted DPS users from accessing this endpoint. This is because we now allow all users to access the /dps_cookie page (which is not ideal and should be fixed ASAP). This change will prevent them from doing anything useful with that page. Eventually though we'll want to revert this to the previous state.

@aileendds aileendds requested a review from chrisgilmerproj Mar 4, 2019

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

⭐️

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #1811 into master will decrease coverage by 0.14%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1811      +/-   ##
==========================================
- Coverage   49.14%   48.99%   -0.15%     
==========================================
  Files         424      422       -2     
  Lines       18129    18074      -55     
  Branches     1622     1621       -1     
==========================================
- Hits         8909     8856      -53     
+ Misses       8440     8438       -2     
  Partials      780      780
1 similar comment
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #1811 into master will decrease coverage by 0.14%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1811      +/-   ##
==========================================
- Coverage   49.14%   48.99%   -0.15%     
==========================================
  Files         424      422       -2     
  Lines       18129    18074      -55     
  Branches     1622     1621       -1     
==========================================
- Hits         8909     8856      -53     
+ Misses       8440     8438       -2     
  Partials      780      780

@aileendds aileendds merged commit 586cb3f into master Mar 4, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: client_test_coverage Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 49.14%)
Details
codecov/project Absolute coverage decreased by -0.14% but relative coverage increased by +50.85% compared to 446d8b6
Details

@aileendds aileendds deleted the fix_dps_auth_endpoint branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.