Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cg 163599170 use only absolute pathnames not null #1813

Merged
merged 2 commits into from Mar 5, 2019

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj commented Mar 4, 2019

Description

This updates #1687 to allow us to still use the request url. It simply converts the url to a pathname only value. It also removes the Explore bar.

Based some of this work from @stangah 's PR #1727

Setup

Try out swagger queries like this one from the UI: http://milmovelocal:3000/internal/docs#/service_members/createServiceMember

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

@chrisgilmerproj chrisgilmerproj self-assigned this Mar 4, 2019

@chrisgilmerproj chrisgilmerproj requested review from jim , Ryan-Koch and stangah Mar 4, 2019

@chrisgilmerproj chrisgilmerproj force-pushed the cg_163599170_use_only_absolute_pathnames_not_null branch from 59ec2fe to 9b18dbc Mar 4, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #1813 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1813      +/-   ##
==========================================
+ Coverage   49.05%   49.13%   +0.07%     
==========================================
  Files         425      423       -2     
  Lines       18180    18122      -58     
  Branches     1630     1621       -9     
==========================================
- Hits         8918     8904      -14     
+ Misses       8482     8438      -44     
  Partials      780      780
@stangah

stangah approved these changes Mar 5, 2019

Copy link
Contributor

stangah left a comment

lgtm!

@chrisgilmerproj chrisgilmerproj merged commit 0d85516 into master Mar 5, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: client_test_coverage Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing d12b0c1...9b18dbc
Details
codecov/project 49.13% (+0.07%) compared to d12b0c1
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_163599170_use_only_absolute_pathnames_not_null branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.