Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 6 more DPS users #1815

Merged
merged 2 commits into from Mar 5, 2019

Conversation

2 participants
@aileendds
Copy link
Contributor

aileendds commented Mar 5, 2019

Whitelisting some more emails. A couple are for me to test other scenarios in staging

@aileendds aileendds requested review from chrisgilmerproj and akostibas Mar 5, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #1815 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1815      +/-   ##
==========================================
+ Coverage   49.07%   49.07%   +<.01%     
==========================================
  Files         425      422       -3     
  Lines       18175    18098      -77     
  Branches     1630     1621       -9     
==========================================
- Hits         8919     8882      -37     
+ Misses       8479     8437      -42     
- Partials      777      779       +2
INSERT INTO public.dps_users VALUES ('065d4f48-63f3-4e03-afe2-4af769d76d6a', 'test@example.com', '2019-03-04 20:37:01.943686', '2019-03-04 20:37:01.943686');
INSERT INTO public.dps_users VALUES ('c9aa6620-cc61-46d7-a2a5-a52312bb422f', 'test@example.com', '2019-03-04 20:37:01.943686', '2019-03-04 20:37:01.943686');
INSERT INTO public.dps_users VALUES ('54728067-edb4-4877-b679-011df41a2ace', 'test@example.com', '2019-03-04 20:37:01.943686', '2019-03-04 20:37:01.943686');
INSERT INTO public.dps_users VALUES ('926af5d7-86c4-4dc4-bbfa-ac2ea3064a91', 'test@example.com', '2019-03-04 20:37:01.943686', '2019-03-04 20:37:01.943686');

This comment has been minimized.

@chrisgilmerproj

chrisgilmerproj Mar 5, 2019

Contributor

For the local migration you really don't need to add any records. You're welcome to, or maybe just add one, but this just ends up being test data we don't need.

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

🚀

@aileendds aileendds merged commit 61aabce into master Mar 5, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: client_test_coverage Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 0d85516...f6843c2
Details
codecov/project 49.07% (+<.01%) compared to 0d85516
Details

@aileendds aileendds deleted the add_more_dps_users branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.