Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidates DB_PORT_TEST, adds go-test script #1817

Merged
merged 2 commits into from Mar 5, 2019

Conversation

2 participants
@stangah
Copy link
Contributor

stangah commented Mar 5, 2019

Description

I'm lazy, and writing DB_PORT=5433 before all my tests seemed like too much work. This PR takes DB_PORT_TEST out of Makefile and elsewhere and puts it into .envrc, then creates a thin wrapper around go test that sets the correct port for developers.

@stangah stangah requested review from jim , chrisgilmerproj and lynzt Mar 5, 2019

# For example: bin/go-test ./pkg/models
#

DB_PORT=$DB_PORT_TEST go test "$@"

This comment has been minimized.

@chrisgilmerproj
bin/go-test Outdated
@@ -0,0 +1,7 @@
#!/bin/bash

This comment has been minimized.

@chrisgilmerproj

chrisgilmerproj Mar 5, 2019

Contributor

#! /usr/bin/env bash please ;)

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

Thanks! Could you announce the new script to engineering?

@stangah stangah merged commit 31a8454 into master Mar 5, 2019

17 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: client_test_coverage Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details

@stangah stangah deleted the ps-go-test branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.