Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResponseForErrors should use Info logging per the logging guidelines. #1873

Merged
merged 1 commit into from Mar 15, 2019

Conversation

3 participants
@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj commented Mar 15, 2019

Description

These errors should be at the Info level instead of the Debug level per our own logging guidelines: https://github.com/transcom/mymove/blob/master/docs/backend.md#logging-levels

Code Review Verification Steps

  • Code follows the guidelines for Logging
  • Request review from a member of a different team.

References

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #1873 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1873   +/-   ##
=======================================
  Coverage   50.31%   50.31%           
=======================================
  Files         440      440           
  Lines       19069    19069           
  Branches     1636     1636           
=======================================
  Hits         9594     9594           
  Misses       8634     8634           
  Partials      841      841
@jamesatheyDDS
Copy link
Contributor

jamesatheyDDS left a comment

Assuming that the Logging guidelines are in fact appropriate, then this PR does exactly what it says on the tin.

@pjdufour-truss
Copy link
Contributor

pjdufour-truss left a comment

Pending any future changes, good to stick with the guide. So 👍

@chrisgilmerproj chrisgilmerproj merged commit 6695a00 into master Mar 15, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: client_test_coverage Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 614abbc...cf53ba3
Details
codecov/project 50.31% remains the same compared to 614abbc
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_response_for_errors_info branch Mar 15, 2019

mkrump added a commit that referenced this pull request Mar 18, 2019

Merge pull request #1873 from transcom/cg_response_for_errors_info
ResponseForErrors should use Info logging per the logging guidelines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.