Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Turn save-fuel-price-data into a task we can run in AWS #1923
Requires we first set up AWS in transcom/ppp-infra#487
This PR containerizes
I've made a few updates to the script so we can target the correct database parameters.
You can immediately try the containerized version using:
This will build a container locally and then run the binary, which is the only thing in that container other than the DB definition. All environment vars are passed through to the container but we could instead use flags if needed.
The rest of the deploy process is a bit more hairy and follows this order:
The script needs to be rewritten and tested as its only a copy of
Download the container to check it out:
Code Review Verification Steps
I'd love for a closer look at the two scripts I've created/modified. The circleci config may need scrutiny too. And finally I am hoping to get in #2049 before this one so I can eliminate a lot of the changes I made to the Makefile in this PR.
@@ Coverage Diff @@ ## master #1923 +/- ## ========================================== + Coverage 60.15% 60.16% +0.01% ========================================== Files 222 222 Lines 13248 13240 -8 ========================================== - Hits 7969 7965 -4 + Misses 4310 4306 -4 Partials 969 969
@kimallen - I made the changes. Can you approve? I'll still wait for one approval from Infra too, but I'd like at least your sign off.