Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding secure migration for new office users #1935

Merged
merged 1 commit into from Apr 1, 2019

Conversation

3 participants
@reggieriser
Copy link
Contributor

reggieriser commented Mar 29, 2019

Description

This PR adds the new office users to the production environment (only) that are noted in the linked Pivotal story below.

Reviewer Notes

No additional users are added to staging, experimental, or development.

Setup

Normally, you could just run bin/run-prod-migrations and verify that the new users were loaded. However, we have a known problem at the moment with an earlier migration breaking when doing so, so you'll need to do the following instead. NOTE: This will reset your dev database, so back it up first with ./bin/db-backup dev if you need to keep anything in it.

make db_dev_destroy db_dev_run
./bin/run-prod-migrations

You can also run ./bin/download-secure-migration 20190329144450_add_office_users.sql to see the contents of the secure migrations in each environment. Just be sure to delete the downloaded files afterwards.

Code Review Verification Steps

  • Any new migrations/schema changes:
    • Secure migrations have been tested using bin/run-prod-migrations
  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #1935 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1935      +/-   ##
==========================================
+ Coverage   60.48%   60.56%   +0.08%     
==========================================
  Files         193      192       -1     
  Lines       12236    12220      -16     
==========================================
  Hits         7400     7400              
+ Misses       3968     3952      -16     
  Partials      868      868

@reggieriser reggieriser requested a review from chrisrcoles Apr 1, 2019

@tinyels

tinyels approved these changes Apr 1, 2019

Copy link
Contributor

tinyels left a comment

:shipit:

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

🚀 - Ran this locally and it worked!

@reggieriser reggieriser merged commit 0d88b70 into master Apr 1, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 586b146...180d907
Details
codecov/project/go 60.38% (+0.08%) compared to 586b146
Details

@reggieriser reggieriser deleted the rr-164966594-new-office-users branch Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.