Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Create a dedicated DB for testing prod-migrations #1945
Adding the role
The new DB runs in a container on port 5434. Everyone will need to update their SQL Editor to use that port if they want to connect.
With this abstraction we should be able to make
direnv allow run-prod-migrations
Code Review Verification Steps
@@ Coverage Diff @@ ## master #1945 +/- ## ========================================== - Coverage 60.51% 60.29% -0.22% ========================================== Files 193 192 -1 Lines 12245 12143 -102 ========================================== - Hits 7409 7321 -88 + Misses 3968 3961 -7 + Partials 868 861 -7
reggieriser left a comment
I added a couple of comments about some duplication in settings that I noticed, but those might be OK/expected since I haven't dug through the build infrastructure in detail.