Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the broken path to soda binary so secure migrations script works #1954

Merged
merged 1 commit into from Apr 3, 2019

Conversation

3 participants
@rdhariwal
Copy link
Contributor

rdhariwal commented Apr 3, 2019

Description

The secure migrations script used to live in bin directory and soda binary was locally available. A recent refactor broke the link and this pr fixes it.

Reviewer Notes

generate-secure-migration does not error out because it cannot find soda binary. See screenshot for more.

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

Screenshots

image

fix the broken path to soda binary so secure migrations script looks …
…at bin directory instead of scripts directory

@rdhariwal rdhariwal marked this pull request as ready for review Apr 3, 2019

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

🎉

@rdhariwal rdhariwal merged commit 2caa7c7 into master Apr 3, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing a4ab5e3...3c1b38f
Details
codecov/project/go 60.46% remains the same compared to a4ab5e3
Details

@rdhariwal rdhariwal deleted the rd-fix-soda-path branch Apr 3, 2019

@lynzt

This comment has been minimized.

Copy link
Contributor

lynzt commented Apr 3, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.