Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Suppress bad moves in list: 164439301 #1959
Suppress bad/testing moves from showing in office and tsp queues list.
NOTE: The secure files for all 3 environments are different.
on this branch:
Ensure the moves listed in
Code Review Verification Steps
@@ Coverage Diff @@ ## master #1959 +/- ## ========================================== - Coverage 60.56% 60.51% -0.04% ========================================== Files 193 193 Lines 12491 12500 +9 ========================================== Hits 7564 7564 - Misses 4044 4053 +9 Partials 883 883
referenced this pull request
Apr 4, 2019
chrisgilmerproj left a comment
I've tested the migrations and they work as expected in all environments.
I would love to see an e2e test added to this where you add a move to the DB that is intentionally suppressed and then check the queue to ensure it isn't there. Alternatively, you could make unit tests in golang that prove this feature works. Or both! But adding tests here would be good.
Thanks for being patient with me while I reviewed your migrations.