Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower case email of all office users #1966

Merged
merged 1 commit into from Apr 4, 2019

Conversation

4 participants
@reggieriser
Copy link
Contributor

reggieriser commented Apr 4, 2019

Description

We had some office users that had mixed-case e-mail addresses in the office_users table (set via secure migrations). Right now, we lower-case the user's input, but compare against the mixed-case address in the database. This migration makes all office user e-mail addresses lower-case for now until we have a longer-term fix.

Setup

Set a couple of e-mail addresses in your local database to have mixed case, then run make db_dev_migrate and verify that they are updated to lower case.

@kahlouie
Copy link
Contributor

kahlouie left a comment

:shipit:

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

🚀 - Approved. But I think we're going to have to find a solution for all email fields across our app. Looking in other tables I see mixed cases as well.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #1966 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1966      +/-   ##
==========================================
- Coverage    60.6%   60.56%   -0.04%     
==========================================
  Files         192      192              
  Lines       12259    12251       -8     
==========================================
- Hits         7429     7419      -10     
- Misses       3952     3953       +1     
- Partials      878      879       +1

@reggieriser reggieriser merged commit 23ce016 into master Apr 4, 2019

18 of 19 checks passed

codecov/project/go 60.39% (-0.04%) compared to 1c6824b
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 1c6824b...3a36d78
Details

@reggieriser reggieriser deleted the rr-lowercase-office-users branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.