Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prod migration targets to makefile for all environments #1967

Merged
merged 1 commit into from Apr 4, 2019

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj commented Apr 4, 2019

Description

I needed a better way to test out each environment for #1959 . This should make it easier to test each env.

Try:

make run_prod_migrations
make run_staging_migrations
make run_experimental_migrations

@chrisgilmerproj chrisgilmerproj self-assigned this Apr 4, 2019

@lynzt

lynzt approved these changes Apr 4, 2019

Copy link
Contributor

lynzt left a comment

this looks like a really great feature to enable testing the 3 environment files...
🚢

# ----- START PROD MIGRATION TARGETS -----
#

.PHONY: run_prod_migrations

This comment has been minimized.

Copy link
@lynzt

lynzt Apr 4, 2019

Contributor

I like being able to target what scripts to run... nice.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #1967 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1967      +/-   ##
==========================================
+ Coverage    60.6%   60.66%   +0.06%     
==========================================
  Files         192      193       +1     
  Lines       12259    12283      +24     
==========================================
+ Hits         7429     7451      +22     
- Misses       3952     3953       +1     
- Partials      878      879       +1

@chrisgilmerproj chrisgilmerproj merged commit c6cb178 into master Apr 4, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 1c6824b...53a506f
Details
codecov/project/go 60.49% (+0.06%) compared to 1c6824b
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_prod_migrations_in_all_envs branch Apr 4, 2019

@chrisgilmerproj chrisgilmerproj referenced this pull request Apr 4, 2019

Open

Suppress bad moves in list: 164439301 #1959

2 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.