Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed .python-version which is vestigial #1970

Merged
merged 1 commit into from Apr 5, 2019

Conversation

2 participants
@ntwyman
Copy link
Contributor

ntwyman commented Apr 4, 2019

Description

Looks like #878 left a dangling .python-version file around. Nothing seems to use it these days or others would have tripped over it. I only found it because the CLI version of VS Code uses python in its launch script and was failing because of it.

@ntwyman ntwyman requested review from chrisgilmerproj and stangah Apr 4, 2019

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

🔥

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #1970 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1970      +/-   ##
==========================================
- Coverage   60.67%   60.59%   -0.08%     
==========================================
  Files         193      192       -1     
  Lines       12300    12274      -26     
==========================================
- Hits         7463     7437      -26     
  Misses       3958     3958              
  Partials      879      879

@ntwyman ntwyman merged commit 0bf0ad7 into master Apr 5, 2019

18 of 19 checks passed

codecov/project/go 60.42% (-0.09%) compared to 6bdfa5a
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6bdfa5a...bfaf11c
Details

@ntwyman ntwyman deleted the nt-remove-python-version branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.