Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SECURE_MIGRATION_BUCKET_NAME to config file for deployment #1976

Merged
merged 1 commit into from Apr 6, 2019

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

commented Apr 5, 2019

Description

The variable is needed in the deployment process for circleci.

{
"name": "SECURE_MIGRATION_BUCKET_NAME",
"value": "transcom-ppp-app-{{ .environment }}-us-west-2"
},

This comment has been minimized.

Copy link
@chrisgilmerproj

chrisgilmerproj Apr 5, 2019

Author Contributor

This is what was missing.

@kahlouie
Copy link
Contributor

left a comment

:shipit:

@codecov

This comment has been minimized.

Copy link

commented Apr 6, 2019

Codecov Report

Merging #1976 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1976      +/-   ##
==========================================
- Coverage   60.67%   60.52%   -0.15%     
==========================================
  Files         193      192       -1     
  Lines       12300    12253      -47     
==========================================
- Hits         7463     7416      -47     
  Misses       3958     3958              
  Partials      879      879

@kahlouie kahlouie merged commit 9b25a58 into master Apr 6, 2019

18 of 19 checks passed

codecov/project/go 60.35% (-0.16%) compared to 70a84d8
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 70a84d8...32d6f63
Details

@kahlouie kahlouie deleted the cg_fix_secure_migrations branch Apr 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.