Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script for uploading migrations to actually test running the migrations #1977

Merged
merged 3 commits into from Apr 8, 2019

Conversation

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj commented Apr 6, 2019

Description

This script was always supposed to check migrations on your behalf. Unfortunately I changed the make targets for prod migrations and this broke, meaning most people making migrations weren't testing before pushing these up. This fixes the script. It also adds one last manual check before upload to ensure you want to do the upload.

Setup

If you want to run this locally just download a file and re-upload that same file:

download-secure-migration 20190405161919_remove-patrick-s.sql
cp tmp/secure_migrations/prod/20190405161919_remove-patrick-s.sql .
upload-secure-migration 20190405161919_remove-patrick-s.sql
@donaldthai
Copy link
Contributor

donaldthai left a comment

Thanks for fixing this! :shipit:

@chrisgilmerproj chrisgilmerproj merged commit 4f99163 into master Apr 8, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 9b25a58...922e601
Details
codecov/project/go 60.51% remains the same compared to 9b25a58
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_fix_upload_migrations_script branch Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.