Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add and wire up swagger file for admin API #1980

Open
wants to merge 9 commits into
base: master
from

Conversation

3 participants
@reggieriser
Copy link
Contributor

reggieriser commented Apr 8, 2019

Description

This PR adds and wires up a swagger file for the admin API.

Reviewer Notes

Note that I have a placeholder endpoint with no implementation currently in the admin.yaml swagger file. Without any endpoints, go-swagger will throw an error. This will be removed as we add actual admin endpoints.

I have marked this is a WIP because it is blocked by an infra story.

Setup

  1. make server_run
  2. make admin_client_run
  3. Try the following local URLs:

Code Review Verification Steps

  • Code follows the guidelines for Logging
  • This works in Supported Browsers (Chrome, Firefox, IE, Edge).
  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #1980 into master will decrease coverage by 0.12%.
The diff coverage is 21.43%.

@@            Coverage Diff             @@
##           master    #1980      +/-   ##
==========================================
- Coverage   60.34%   60.22%   -0.12%     
==========================================
  Files         193      192       -1     
  Lines       12536    12547      +11     
==========================================
- Hits         7564     7556       -8     
- Misses       4083     4100      +17     
- Partials      889      891       +2
@@ -165,6 +165,7 @@ commands:
LOGIN_GOV_MY_CLIENT_ID: urn:gov:gsa:openidconnect.profiles:sp:sso:dod:mymovemillocal
LOGIN_GOV_OFFICE_CLIENT_ID: urn:gov:gsa:openidconnect.profiles:sp:sso:dod:officemovemillocal
LOGIN_GOV_TSP_CLIENT_ID: urn:gov:gsa:openidconnect.profiles:sp:sso:dod:tspmovemillocal
LOGIN_GOV_ADMIN_CLIENT_ID: urn:gov:gsa:openidconnect.profiles:sp:sso:dod:adminmovemillocal

This comment has been minimized.

Copy link
@chrisgilmerproj

chrisgilmerproj Apr 8, 2019

Contributor

I still don't have this made. I'll try to figure out how to make the cert shortly.

This comment has been minimized.

Copy link
@chrisgilmerproj

chrisgilmerproj Apr 9, 2019

Contributor

Done, I have created the app. You are now set to use this so try it out!

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

Putting a hold on this until we get the cert up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.