Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added verbose flag when executing go get -u=patch #1981

Merged
merged 1 commit into from Apr 10, 2019

Conversation

4 participants
@rdhariwal
Copy link
Contributor

rdhariwal commented Apr 8, 2019

Description

go_deps_update will now execute get get -u=patch with -v aka verbose flag so we can debug and fix dependency updating issues faster.

Setup

Add any steps or code to run in this section to help others prepare to run your code:

make go_deps_update

References

@rdhariwal rdhariwal marked this pull request as ready for review Apr 8, 2019

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

I'm approving. It's worth noting that this is only used by the circleci config or by manual use. But its not tied to anything else. So the extra output from -v will only show up in the CircleCI logs.

@kahlouie
Copy link
Contributor

kahlouie left a comment

yay better error messages in circle!

@rdhariwal rdhariwal force-pushed the rd-verbose-dep-updation branch from ea09499 to 803bad1 Apr 9, 2019

@rdhariwal rdhariwal merged commit 567d6ec into master Apr 10, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 77cc059...803bad1
Details
codecov/project/go 60.39% remains the same compared to 77cc059
Details

@rdhariwal rdhariwal deleted the rd-verbose-dep-updation branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.