Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running prod migrations locally first before upload #1993

Merged
merged 2 commits into from Apr 10, 2019

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj commented Apr 10, 2019

Description

Fixes a mistake I made when updating this script. This should test locally running the migration first before uploading to s3 as opposed the the chicken-and-egg problem I'd created with testing s3 before uploading to s3.

@chrisgilmerproj chrisgilmerproj requested a review from donaldthai Apr 10, 2019

@donaldthai
Copy link
Contributor

donaldthai left a comment

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #1993 into master will decrease coverage by 0.64%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1993      +/-   ##
==========================================
- Coverage   61.01%   60.37%   -0.64%     
==========================================
  Files         193      193              
  Lines       12384    12521     +137     
==========================================
+ Hits         7555     7559       +4     
- Misses       3940     4073     +133     
  Partials      889      889

@chrisgilmerproj chrisgilmerproj merged commit a95e7d8 into master Apr 10, 2019

18 of 19 checks passed

codecov/project/go 60.2% (-0.65%) compared to 567d6ec
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 567d6ec...b452c4d
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_test_prod_migrations_locally_first branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.