Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure Migration Update Users to Super User [delivers #164995501] #1994

Merged
merged 3 commits into from Apr 10, 2019

Conversation

2 participants
@donaldthai
Copy link
Contributor

commented Apr 10, 2019

Description

This PR updates existing users to super user status via a secure migration. Check pivotal story for more details.

This also removes SECURE_MIGRATION_SOURCE from .envrc file.

Setup

Add any steps or code to run in this section to help others prepare to run your code:

To run these migrations on your database and verify the data, run:

make run_prod_migrations, then inspect the prod_migrations database that was created in your local postgres.

Code Review Verification Steps

Any new migrations/schema changes:

  • Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
  • Have been communicated to #dp3-engineering
  • Secure migrations have been tested using scripts/run-prod-migrations
  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

donaldthai added some commits Apr 10, 2019

@donaldthai donaldthai changed the title Secure Migration Update Users to Super User Secure Migration Update Users to Super User [delivers #164995501] Apr 10, 2019

@chrisgilmerproj
Copy link
Contributor

left a comment

🚀

@codecov

This comment has been minimized.

Copy link

commented Apr 10, 2019

Codecov Report

Merging #1994 into master will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1994      +/-   ##
==========================================
+ Coverage   60.22%   60.37%   +0.15%     
==========================================
  Files         192      193       +1     
  Lines       12474    12521      +47     
==========================================
+ Hits         7512     7559      +47     
  Misses       4073     4073              
  Partials      889      889

@donaldthai donaldthai merged commit 3ece928 into master Apr 10, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing a95e7d8...af5cc5b
Details
codecov/project/go 60.2% (+0.15%) compared to a95e7d8
Details

@donaldthai donaldthai deleted the dt-164995501-update-super-users branch Apr 10, 2019

@donaldthai donaldthai added the 🦇team label Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.