Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cg fix apply secure migration #1997

Merged
merged 2 commits into from Apr 11, 2019

Conversation

3 participants
@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj commented Apr 11, 2019

Description

Sets a sane default for the required variable SECURE_MIGRATION_SOURCE.

Catches a problem introduced in #1994 .

Setup

make db_dev_reset db_dev_migrate
make db_test_reset db_test_migrate

@chrisgilmerproj chrisgilmerproj requested review from jim, mkrump and ralren Apr 11, 2019

@chrisgilmerproj chrisgilmerproj self-assigned this Apr 11, 2019

@mkrump

mkrump approved these changes Apr 11, 2019

@chrisgilmerproj chrisgilmerproj requested a review from donaldthai Apr 11, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #1997 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1997      +/-   ##
==========================================
+ Coverage   60.38%   60.39%   +<.01%     
==========================================
  Files         193      192       -1     
  Lines       12525    12503      -22     
==========================================
- Hits         7563     7550      -13     
+ Misses       4073     4064       -9     
  Partials      889      889
@donaldthai
Copy link
Contributor

donaldthai left a comment

We missed one huh? Doh. :shipit:

@chrisgilmerproj chrisgilmerproj merged commit 6e2bbc4 into master Apr 11, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 3f2a382...147106a
Details
codecov/project/go 60.21% (+<.01%) compared to 3f2a382
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_fix_apply_secure_migration branch Apr 11, 2019

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

chrisgilmerproj commented Apr 11, 2019

We missed one huh? Doh. :shipit:

This one's on me. I definitely searched for other instances and just misread what this line was doing. Fortunately its an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.