Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure login case insensitivity #2002

Merged
merged 1 commit into from Apr 15, 2019

Conversation

3 participants
@chrisrcoles
Copy link
Contributor

chrisrcoles commented Apr 11, 2019

Description

This PR ensures that login does a case insensitive comparison for the email column for dps_user, tsp_user, and office_user tables.

Setup

  1. ./bin/make-office-user --email Email
  • Email must start with a capital letter
  • You must have access to Email
  1. make office_client_run
  2. make server_run
  3. Go to the office client in the browser.
  4. Click Sign In
  5. Sign in or Create an Account with the same Email as above, but lower case.
  6. Complete the 2MFA Verification Step
  7. Click Next
  8. Before you would have seen a white screen that says Unauthorized. Now, it continues.

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #2002 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2002      +/-   ##
==========================================
+ Coverage   60.38%   60.42%   +0.03%     
==========================================
  Files         193      193              
  Lines       12525    12525              
==========================================
+ Hits         7563     7567       +4     
+ Misses       4073     4067       -6     
- Partials      889      891       +2
@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

Nice work! I also like that you got the name Chris in the tests :)

@reggieriser
Copy link
Contributor

reggieriser left a comment

Looks good! 🚢

User: chris,
TransportationOfficeID: office.ID,
}
suite.MustSave(&officeUser)

This comment has been minimized.

Copy link
@reggieriser

reggieriser Apr 11, 2019

Contributor

We might be able to use our Assertions object and MakeOfficeUser to simplify this, but I see the rest of the file uses a similar pattern, so I'd probably rather stay consistent unless we want to refactor the other tests here too.

@chrisrcoles chrisrcoles merged commit 117f6a8 into master Apr 15, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 60.38%)
Details
codecov/project/go 60.24% (+0.03%) compared to bbaf6ae
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.