Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go dependencies not affected by the issue with googlesource repos #2008

Open
wants to merge 4 commits into
base: master
from

Conversation

4 participants
@jim
Copy link
Contributor

jim commented Apr 12, 2019

Waiting on the following to be resolved: golang/go#31399

Description

It seems that in the switch from dep to go mod a bunch of our dependencies were downgraded, probably due to how go mod uses the minimum version that will satisfy requirements for indirect dependencies.

This PR updates most of our dependencies to the latest version.

Reviewer Notes

go get -u is current broken due to an issue with JGit and go mod that should be resolved soon. I used a small Ruby script to perform the updates in this PR:

output = `go mod graph`
deps = output.each_line.map do |l|
  l.gsub("github.com/transcom/mymove ", "").split("@")[0]
end.uniq.sort

deps.each do |dep|
  print dep
  print "... "

  trace = `go get -u #{dep} 2>&1`
  if $? == 0
    puts "done."
  else
    puts trace
  end
end

Code Review Verification Steps

  • Request review from a member of a different team.

References

@jim jim requested review from chrisgilmerproj and pjdufour-truss Apr 12, 2019

@pjdufour-truss
Copy link
Contributor

pjdufour-truss left a comment

Since we don't have a tagged release on github.com/trussworks/pdfcpu for our afero work, you need to run the following to tag the latest commit on the afero branch.

go get github.com/trussworks/pdfcpu@afero
## Update a specific dependency

```console
$ go get -u github.com/pkg/errors

This comment has been minimized.

Copy link
@chrisgilmerproj

chrisgilmerproj Apr 15, 2019

Contributor

Would be nice to also have an example of getting the dependency @master, which I think is the right syntax. I think a lot of our deps we want at the master version.

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

I'd love one more thing added to the README. But I'm not going to block. Thanks for doing this.

@jim jim added the roci label Apr 15, 2019

@pjdufour-truss

This comment has been minimized.

Copy link
Contributor

pjdufour-truss commented Apr 15, 2019

This PR is reverts cobra, viper, and pflag. Since we want master branch for those, so this is still blocked.

@ralren

ralren approved these changes Apr 15, 2019

Copy link
Contributor

ralren left a comment

Looks good. All the different apps ran fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.