Add go-vet shadow variable checking. #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2042 +/- ##
==========================================
+ Coverage 60.26% 60.29% +0.03%
==========================================
Files 229 230 +1
Lines 13331 13342 +11
==========================================
+ Hits 8033 8044 +11
Misses 4326 4326
Partials 972 972 |
added 25 commits
April 25, 2019 15:58
chrisgilmerproj
commented
Apr 25, 2019
scripts/pre-commit-go-vet
Outdated
| # Get directory of script in order to get directory of project | ||
| # This allows the script to work from any sub directory in the project | ||
| DIR="$( cd "$( dirname "${BASH_SOURCE[0]}/" )" >/dev/null 2>&1 && pwd )" | ||
| DIR="$(dirname "${DIR}")" |
There was a problem hiding this comment.
@chrisrcoles - this ought to fix the problem you saw today.
|
This works on experimental. But I saw a failure with the awardqueue and I'm worried about it. So I'm going to check that out first and try to find out what's up. |
This reverts commit ef699b6.
Subsequent reruns worked. Though please give a closer look if you can and try to catch anything I messed up. |
added 2 commits
April 26, 2019 21:52
chrisgilmerproj
commented
May 3, 2019
| @@ -582,7 +582,7 @@ func showFunction(cmd *cobra.Command, args []string) error { | |||
| } | |||
|
|
|||
| if level := strings.ToLower(v.GetString(flagLogLevel)); len(level) > 0 { | |||
| filters[logLevel] = level | |||
| filters[filterLogLevel] = level | |||
There was a problem hiding this comment.
@pjdufour-truss - found this shadow variable and was hoping you'd take a look at it. I think I made the appropriate fix.
|
@akostibas - I keep seeing this problem with the award queue. Any idea what's up with this? |
|
Turns out the awardqueue problem wasn't part of this PR. It was fixed in #2093 |
chrisgilmerproj
requested review from
mikena-truss,
reggieriser and
ralren
and removed request for
akostibas,
sarboc,
jacquelineIO and
jim
reggieriser
reviewed
May 8, 2019
| h.Logger().Error("DB Query", zap.Error(err)) | ||
| tspUser, fetchTSPByUserErr := models.FetchTspUserByID(h.DB(), session.TspUserID) | ||
| if fetchTSPByUserErr != nil { | ||
| h.Logger().Error("DB Query", zap.Error(fetchTSPByUserErr)) | ||
| // return tspop.NewGetTransporationServiceProviderForbidden() | ||
| } |
There was a problem hiding this comment.
There's some code below this that uses the err but doesn't shadow. Your fix is fine, but just noting that it feels a little odd when we're using the err from the earlier scope, but only on the second call in this block.
There was a problem hiding this comment.
go-vet isn't perfect, I'm pretty sure it just uses statistical modeling to find these things. But in at least a few cases it caught real problems with the code and I'm happy with that result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We lost shadow variable checking when we moved from
go tool vettogo vet. This PR fixes that oversight and any missed vars.Reviewer Notes
Here are the problems I have to fix:
Setup
Add any steps or code to run in this section to help others prepare to run your code:
Code Review Verification Steps
References