Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication POST issues #2071

Merged
merged 3 commits into from May 2, 2019

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

commented May 1, 2019

Description

While doing load testing in #1597 I found out that I needed to read form values more strictly. Also the logic for validating sessions is not as clean as it ought to be. So this does two things:

  • Get values from form using PostFormValues so the form doesn't have to be parsed
  • Disambiguate getting a session from checking the user id.

Setup

You should still be able to log into the devlocal page and sign in as or create a new devlocal user.

You can also use the demo script in #1597 to try it out.

Disambiguate getting a session from checking the user id. Also get va…
…lues from form using PostFormValues so the form doesn't have to be parsed

@chrisgilmerproj chrisgilmerproj self-assigned this May 1, 2019

@chrisgilmerproj chrisgilmerproj referenced this pull request May 1, 2019

Open

WIP - Try out load testing framework locust.io #1597

0 of 2 tasks complete
@codecov

This comment has been minimized.

Copy link

commented May 1, 2019

Codecov Report

Merging #2071 into master will not change coverage.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##           master    #2071   +/-   ##
=======================================
  Coverage   60.15%   60.15%           
=======================================
  Files         222      222           
  Lines       13247    13247           
=======================================
  Hits         7968     7968           
  Misses       4310     4310           
  Partials      969      969

@chrisgilmerproj chrisgilmerproj requested a review from ralren May 2, 2019

@rdhariwal
Copy link
Contributor

left a comment

🚀

@chrisgilmerproj chrisgilmerproj merged commit e3cb0ac into master May 2, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch 85.71% of diff hit (target 60.15%)
Details
codecov/project/go 59.98% (+0%) compared to 4f13eca
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_post_form_value branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.