Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique Devlocal Users #2072

Merged
merged 1 commit into from May 2, 2019

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

commented May 1, 2019

Description

Email collision happens when automated testing run because time is not unique enough by itself to disambiguate. For example, when letting load-testing in #1597 create users it can do it at a rate faster than the time stamp will change, which means you get weird session authentication errors for users with the same email.

Reviewer Notes

Is there a better way to get uniqueness? Or should I just be using the full uuid as the email address instead of the time?

Setup

You can use the demo script in #1597 to see the problem happen in real time.

@chrisgilmerproj chrisgilmerproj self-assigned this May 1, 2019

@chrisgilmerproj chrisgilmerproj referenced this pull request May 1, 2019

Open

WIP - Try out load testing framework locust.io #1597

0 of 2 tasks complete
@codecov

This comment has been minimized.

Copy link

commented May 1, 2019

Codecov Report

Merging #2072 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2072      +/-   ##
==========================================
- Coverage   60.15%   60.13%   -0.02%     
==========================================
  Files         222      221       -1     
  Lines       13247    13231      -16     
==========================================
- Hits         7968     7956      -12     
+ Misses       4310     4308       -2     
+ Partials      969      967       -2

@chrisgilmerproj chrisgilmerproj requested a review from kahlouie May 2, 2019

@kahlouie
Copy link
Contributor

left a comment

:shipit:

@chrisgilmerproj chrisgilmerproj merged commit 8975017 into master May 2, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 60.15%)
Details
codecov/project/go Absolute coverage decreased by -0.02% but relative coverage increased by +40.02% compared to 4f13eca
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_unique_devlocal_users branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.