Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Swagger Office Queue Spec #2073

Merged
merged 4 commits into from May 2, 2019

Conversation

3 participants
@chrisgilmerproj
Copy link
Contributor

commented May 1, 2019

Description

This supports #1597 load testing.

The swagger spec for the office queue is incorrect and strict interpretation of it by the Yelp Bravado python library throws unrecoverable errors. In particular:

  • Customer Deadline is dead code and is never filled in despite being a required field
  • Either PPM Status or HHG Status can be empty but both are required fields.
  • GBL number is required despite the fact that it doesn't exist until after a GBL is generated so it usually shows up as empty for new moves
  • Move Date is required despite most of the e2e test data not having that data at all and the queue still loads without it.

Reviewer Notes

Apparently this was never caught before because React-Table is loading the data outside of a swagger api request. Per this discussion.

Should we modify the react-table integration to use our swagger endpoint? Drift like this between the swagger spec and our API calls is concerning.

Setup

Run the app and go to the queues page, you should not see any issues.

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

@chrisgilmerproj chrisgilmerproj self-assigned this May 1, 2019

@chrisgilmerproj chrisgilmerproj referenced this pull request May 1, 2019

Open

WIP - Try out load testing framework locust.io #1597

0 of 2 tasks complete
@codecov

This comment has been minimized.

Copy link

commented May 1, 2019

Codecov Report

Merging #2073 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2073      +/-   ##
==========================================
- Coverage   60.15%   60.14%   -0.01%     
==========================================
  Files         222      221       -1     
  Lines       13247    13223      -24     
==========================================
- Hits         7968     7952      -16     
+ Misses       4310     4306       -4     
+ Partials      969      965       -4
@rdhariwal
Copy link
Contributor

left a comment

🚀

@lynzt

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

🚢

@chrisgilmerproj chrisgilmerproj merged commit 8b21772 into master May 2, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 60.15%)
Details
codecov/project/go Absolute coverage decreased by -0.01% but relative coverage increased by +40.02% compared to 4f13eca
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_office_queue_changes branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.