Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Swagger Office Queue Spec #2073
This supports #1597 load testing.
The swagger spec for the office queue is incorrect and strict interpretation of it by the Yelp Bravado python library throws unrecoverable errors. In particular:
Apparently this was never caught before because React-Table is loading the data outside of a swagger api request. Per this discussion.
Should we modify the react-table integration to use our swagger endpoint? Drift like this between the swagger spec and our API calls is concerning.
Run the app and go to the queues page, you should not see any issues.
Code Review Verification Steps
referenced this pull request
May 1, 2019
@@ Coverage Diff @@ ## master #2073 +/- ## ========================================== - Coverage 60.15% 60.14% -0.01% ========================================== Files 222 221 -1 Lines 13247 13223 -24 ========================================== - Hits 7968 7952 -16 + Misses 4310 4306 -4 + Partials 969 965 -4