Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'format: string' from spec since it does nothing and throws warnings #2074

Merged
merged 1 commit into from May 2, 2019

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

commented May 1, 2019

Description

string is not a format as defined by https://swagger.io/docs/specification/data-models/data-types/. In fact its redundant and doesn't add value to the places where it is used. In #1597 the load testing framework throws warnings for these and so I am removing them.

Setup

Run the app, it should have no issues.

Code Review Verification Steps

  • Request review from a member of a different team.
@codecov

This comment has been minimized.

Copy link

commented May 1, 2019

Codecov Report

Merging #2074 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2074      +/-   ##
==========================================
- Coverage   60.15%   60.11%   -0.04%     
==========================================
  Files         222      221       -1     
  Lines       13247    13217      -30     
==========================================
- Hits         7968     7945      -23     
+ Misses       4310     4306       -4     
+ Partials      969      966       -3

@chrisgilmerproj chrisgilmerproj requested a review from SirenaBorracha May 2, 2019

@rdhariwal
Copy link
Contributor

left a comment

:shipit:

@chrisgilmerproj chrisgilmerproj merged commit 88bf6eb into master May 2, 2019

18 of 19 checks passed

codecov/project/go 59.94% (-0.04%) compared to 4f13eca
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 4f13eca...7e82655
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_remove_format_string_from_swagger branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.