Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Enable devlocal auth from flag and use environment checking #2081
To support Load Testing in #1597 we need a way to turn on Devlocal Auth in experimental. This adds a flag that enables the devlocal auth but will check against the deployed environment and server names and fail if the environment is wrong.
Could this be made more safe so we don't enable devlocal auth in production or staging? I am checking devlocal flag against:
The combination here means multiple things need to fail in order to see this deployed in prod/staging.
Run the app. Try changing your
Code Review Verification Steps
referenced this pull request
May 2, 2019
@@ Coverage Diff @@ ## master #2081 +/- ## ========================================== - Coverage 58.78% 58.47% -0.31% ========================================== Files 240 241 +1 Lines 13888 13825 -63 ========================================== - Hits 8164 8084 -80 - Misses 4728 4750 +22 + Partials 996 991 -5