Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected api calls for error handlers in moves ducks. #2082

Merged
merged 1 commit into from May 6, 2019

Conversation

3 participants
@tinyels
Copy link
Contributor

commented May 2, 2019

Description

The error handlers for the moves ducks were calling incorrect apis. I realize this will be replaced soon, but it was an easy fix and one of them caused serious unrecoverable errors if there was a server error updating the move.

Code Review Verification Steps

n/a

@tinyels tinyels requested review from sarboc and chrisgilmerproj May 2, 2019

@codecov

This comment has been minimized.

Copy link

commented May 2, 2019

Codecov Report

Merging #2082 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2082      +/-   ##
==========================================
+ Coverage   60.12%   60.15%   +0.03%     
==========================================
  Files         221      222       +1     
  Lines       13238    13248      +10     
==========================================
+ Hits         7959     7969      +10     
  Misses       4310     4310              
  Partials      969      969
@sarboc

sarboc approved these changes May 3, 2019

Copy link
Contributor

left a comment

:shipit:

@tinyels tinyels merged commit 61da73e into master May 6, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 8b21772...880ae78
Details
codecov/project/go 59.98% (+0.03%) compared to 8b21772
Details

@tinyels tinyels deleted the els-fix-move-ducks branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.