Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Put dev secrets into chamber #2089
NOTE: This does not replace
Many of our newer developers don't have access to GDrive. This means they start the project and cannot get the secrets for their
Here are the secrets added:
What is the user experience like with this?
This should remove the need for much of the
mv .envrc.local .envrc.local.bkp direnv allow touch .envrc.local # Now add back the things you want
Code Review Verification Steps
requested review from
May 7, 2019
I've added a change that makes this work nicely if you either 1) don't have access to AWS SSM, 2) incorrectly enter your MFA token. It now just warns you instead of trying to eval the error statement.
Here is the output of such a call coupled with missing variables:
Does it just not work at all? Because if it acts as a no-op in the fish shell then that's fine and we can work out alternatives later. But if it stops
Personally I'd also like to know how direnv works a little more because our
I also want to re-iterate that this doesn't replace
The alternative is that I can update the docs and just tell people to put this line of code in their
In the meantime I'm going to give you and @akostibas access to our chamber secrets and I'll be curious if that changes the behavior at all. You can try
@tinyels @jim - can you try this branch with the command
So the solution here would be making a script named
Btw, I did download the fish shell and this worked for me so I just want to confirm.