Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cg 165869915 fix dependency updater #2099

Merged
merged 3 commits into from May 8, 2019

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

commented May 7, 2019

Description

Dependency updater has been broken as seen in https://circleci.com/gh/transcom/mymove/104184. It appears that it was a network issue causing a delay in downloading of more than 10 seconds. This PR does:

  • Update timeout to 30 seconds
  • Split up dependency updates so one won't block the other
  • Adds Makefile targets to make testing this stuff easier

Setup

To test the dependency updater:

make dependency_update_test

You can also update deps with

make dependency_update

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

@chrisgilmerproj chrisgilmerproj requested review from jim, donaldthai, LeDeep and sarboc May 7, 2019

@chrisgilmerproj chrisgilmerproj self-assigned this May 7, 2019

@chrisgilmerproj chrisgilmerproj referenced this pull request May 7, 2019

Merged

Dependency updates for 20190507 #2100

1 of 1 task complete
@jim

jim approved these changes May 8, 2019

Copy link
Contributor

left a comment

🚢

@chrisgilmerproj chrisgilmerproj merged commit 614df92 into master May 8, 2019

19 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 17e5a49...e8b8e10
Details
codecov/project/go 60.12% remains the same compared to 17e5a49
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_165869915_fix_dependency_updater branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.