Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates for 20190507 #2100

Merged
merged 2 commits into from May 8, 2019

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

commented May 7, 2019

Description

Catching up on several weeks of dependency updates.

Reviewer Notes

Related to #2099

Code Review Verification Steps

  • Have the Pivotal acceptance criteria been met for this change?

References

@chrisgilmerproj chrisgilmerproj requested review from LeDeep and sarboc May 7, 2019

@chrisgilmerproj chrisgilmerproj self-assigned this May 7, 2019

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

@LeDeep @sarboc - there's one failing test here and I'm having trouble figuring it out. Can you give me an assist on this?

@LeDeep

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

@LeDeep @sarboc - there's one failing test here and I'm having trouble figuring it out. Can you give me an assist on this?

@chrisgilmerproj have you tried rebuilding? The failing test passes for me locally when I checkout your branch.

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

@chrisgilmerproj have you tried rebuilding? The failing test passes for me locally when I checkout your branch.

I did several times. And then I gave up. But it passes locally so I'm at a loss. I could merge master in again and then try and see what happens.

@codecov

This comment has been minimized.

Copy link

commented May 8, 2019

Codecov Report

Merging #2100 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2100      +/-   ##
==========================================
- Coverage   60.36%   60.29%   -0.07%     
==========================================
  Files         229      230       +1     
  Lines       13271    13341      +70     
==========================================
+ Hits         8010     8043      +33     
- Misses       4300     4326      +26     
- Partials      961      972      +11
@LeDeep

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

@chrisgilmerproj have you tried rebuilding? The failing test passes for me locally when I checkout your branch.

I did several times. And then I gave up. But it passes locally so I'm at a loss. I could merge master in again and then try and see what happens.

It didn't appear, on quick glance, that any of the updated dependencies should have an impact on the failing test. Can dig deeper if it continues to fail after merging master.

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

It didn't appear, on quick glance, that any of the updated dependencies should have an impact on the failing test. Can dig deeper if it continues to fail after merging master.

I merged in master and I'm running the tests once more. I'm 🤞 with this one.

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

@LeDeep - Looks like it worked! Can you review and approve? Per the instructions we're supposed to just merge these in if tests pass.

@LeDeep

LeDeep approved these changes May 8, 2019

Copy link
Contributor

left a comment

🚢

@chrisgilmerproj chrisgilmerproj merged commit 13125a4 into master May 8, 2019

18 of 19 checks passed

codecov/project/go 60.12% (-0.07%) compared to 614df92
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 614df92...69e7136
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_165870745_dependency_updates_20190507 branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.