Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with ecs-deploy-task-container having a shadow err var #2108

Merged
merged 1 commit into from May 9, 2019

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

commented May 8, 2019

Description

In #2042 I must have missed one of these shadow vars. This is the fix for master.

Run pre-commit run -a go-vet to check.

@chrisgilmerproj chrisgilmerproj requested review from LeDeep and sarboc May 8, 2019

@chrisgilmerproj chrisgilmerproj self-assigned this May 8, 2019

@codecov

This comment has been minimized.

Copy link

commented May 9, 2019

Codecov Report

Merging #2108 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2108      +/-   ##
==========================================
- Coverage   60.29%   60.18%   -0.12%     
==========================================
  Files         230      230              
  Lines       13342    13218     -124     
==========================================
- Hits         8044     7954      -90     
+ Misses       4326     4309      -17     
+ Partials      972      955      -17
@LeDeep

LeDeep approved these changes May 9, 2019

@chrisgilmerproj chrisgilmerproj merged commit d758635 into master May 9, 2019

19 of 20 checks passed

codecov/project/go 60.01% (-0.12%) compared to 262cb7d
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 262cb7d...1a22701
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_fix_ecs_deploy_go_vet_shadow branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.