Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jen2000 from codeowners file, replace with ARBOC #2110

Merged

Conversation

@chrisgilmerproj
Copy link
Contributor

commented May 9, 2019

Description

@jen2000 has left the Transcom org in transcom/ppp-infra#508. Instead of having only @ntwyman in codeowners I've replaced her with the team leads. Happy to make other changes too but figure we should have more than one person on the ADR review.

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

@chrisgilmerproj chrisgilmerproj self-assigned this May 9, 2019

@tinyels
Copy link
Contributor

left a comment

Shouldn't this be arboc instead?

@jim

jim approved these changes May 9, 2019

Copy link
Contributor

left a comment

I'm 👍 on this. We can continue to discuss changes to our process but there's no need to block the PR on that.

@codecov

This comment has been minimized.

Copy link

commented May 9, 2019

Codecov Report

Merging #2110 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2110      +/-   ##
==========================================
+ Coverage    60.3%   60.34%   +0.04%     
==========================================
  Files         231      230       -1     
  Lines       13373    13355      -18     
==========================================
- Hits         8064     8058       -6     
+ Misses       4334     4325       -9     
+ Partials      975      972       -3
@@ -8,4 +8,4 @@

# ADRs are architectural decisions that, at least for now, should all be run by Nick

This comment has been minimized.

Copy link
@mikena-truss

mikena-truss May 9, 2019

Contributor

I think the comment needs to be updated too.

This comment has been minimized.

Copy link
@chrisgilmerproj

chrisgilmerproj May 9, 2019

Author Contributor

Good catch! I updated it.

@chrisgilmerproj chrisgilmerproj changed the title Remove jen2000 from codeowners file, replace with team leads Remove jen2000 from codeowners file, replace with ARBOC May 9, 2019

@chrisgilmerproj chrisgilmerproj force-pushed the cg_165892140_remove_jen2000_from_codeowners branch from 4f08599 to d02ef81 May 9, 2019

@mikena-truss

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

Thanks!

@chrisgilmerproj chrisgilmerproj merged commit 872413f into master May 9, 2019

20 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 3ef554d...d02ef81
Details
codecov/project/go 60.17% (+0.04%) compared to 3ef554d
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_165892140_remove_jen2000_from_codeowners branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.