Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Abstract AWS Vault for cmd binaries #2114
The code for compare-secure-migrations doesn't have our nice built-in aws-vault integration. In this PR I've broken out the aws-vault command line flags and code for setting up an AWS Config struct. I then modified both compare-secure-migrations and ecs-deploy-task-container to use that code.
In addition I applied the new AWS region stuff to milmove ses and s3 command line flags. I also updated the way we manage tests to ensure specific flags won't fail when running server tests.
I did not modify ecs-ervice-logs because we intend to open source that at some point in the future.
make bin/compare-secure-migrations compare-secure-migrations
Code Review Verification Steps
@@ Coverage Diff @@ ## master #2114 +/- ## ========================================= - Coverage 58.98% 58.78% -0.2% ========================================= Files 238 240 +2 Lines 13807 13888 +81 ========================================= + Hits 8144 8164 +20 - Misses 4673 4728 +55 - Partials 990 996 +6