Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constants for SSL modes and db environments. #2121

Merged
merged 4 commits into from May 13, 2019

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

commented May 10, 2019

Description

This supports #2081

The big change is to check both the db env and the ssl modes against constants. Also removes the -e flag from here so I can re-use it somewhere else.

Setup

go-test ./pkg/cli

Code Review Verification Steps

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
Show resolved Hide resolved pkg/cli/dbconn.go Outdated
@pjdufour-truss
Copy link
Contributor

left a comment

Code looks good, but please update that one comment I identified.

@codecov

This comment has been minimized.

Copy link

commented May 10, 2019

Codecov Report

Merging #2121 into master will decrease coverage by 0.03%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##           master    #2121      +/-   ##
==========================================
- Coverage   58.72%   58.69%   -0.03%     
==========================================
  Files         236      236              
  Lines       13788    13780       -8     
==========================================
- Hits         8097     8088       -9     
+ Misses       4712     4711       -1     
- Partials      979      981       +2

@chrisgilmerproj chrisgilmerproj requested a review from pjdufour-truss May 10, 2019

@pjdufour-truss
Copy link
Contributor

left a comment

🚢

@chrisgilmerproj chrisgilmerproj merged commit 49a2c9c into master May 13, 2019

18 of 20 checks passed

codecov/patch 27.27% of diff hit (target 58.72%)
Details
codecov/project/go 58.5% (-0.03%) compared to 9bf220d
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_cli_dbconn_constants branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.