Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing admin and orders hosts to e2e docker test #2122

Merged
merged 1 commit into from May 10, 2019

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

commented May 10, 2019

Description

I need to add some extra vars to the e2e tests in support of #2081. While I was at it I added the Admin and Orders hosts to the tests to support future tests.

Setup

make e2e_test_docker

Code Review Verification Steps

  • Request review from a member of a different team.
@codecov

This comment has been minimized.

Copy link

commented May 10, 2019

Codecov Report

Merging #2122 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2122      +/-   ##
==========================================
+ Coverage   58.72%   58.73%   +0.01%     
==========================================
  Files         236      237       +1     
  Lines       13788    13797       +9     
==========================================
+ Hits         8097     8103       +6     
- Misses       4712     4714       +2     
- Partials      979      980       +1

@chrisgilmerproj chrisgilmerproj merged commit de13e42 into master May 10, 2019

20 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 9bf220d...7651159
Details
codecov/project/go 58.54% (+0.01%) compared to 9bf220d
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_fix_e2e_docker_with_admin branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.