Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable spelling pre-commit hook #2220

Merged
merged 3 commits into from Jun 4, 2019

Conversation

@chrisgilmerproj
Copy link
Contributor

commented Jun 3, 2019

Description

I noticed a lot of minor nit comments in PRs lately regarding spelling. This re-enables the pre-commit that ought to be checking for those mistakes.

Try with: pre-commit run -a mdspell

If you find spelling problems try make spellcheck

@codecov

This comment has been minimized.

Copy link

commented Jun 3, 2019

Codecov Report

Merging #2220 into master will increase coverage by 0.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2220      +/-   ##
==========================================
+ Coverage   59.01%   59.42%   +0.41%     
==========================================
  Files         250      250              
  Lines       14071    13965     -106     
==========================================
- Hits         8303     8298       -5     
+ Misses       4767     4666     -101     
  Partials     1001     1001

@chrisgilmerproj chrisgilmerproj merged commit b7eac91 into master Jun 4, 2019

19 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing b2afb0d...332be57
Details
codecov/project/go 59.25% (+0.42%) compared to b2afb0d
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_fix_mdspell_pre_commit branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.