Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some targets that are not needed now that we have golangci-lint #2221

Merged
merged 2 commits into from Jun 4, 2019

Conversation

3 participants
@chrisgilmerproj
Copy link
Contributor

commented Jun 3, 2019

Description

Noticed these could all go.

@chrisgilmerproj chrisgilmerproj self-assigned this Jun 3, 2019

@rdhariwal

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

this step probs needs to be removed since it refers get_gotools

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

this step probs needs to be removed since it refers get_gotools

Fixed!

@codecov

This comment has been minimized.

Copy link

commented Jun 3, 2019

Codecov Report

Merging #2221 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2221      +/-   ##
==========================================
- Coverage   58.74%   58.69%   -0.04%     
==========================================
  Files         246      246              
  Lines       13966    13971       +5     
==========================================
- Hits         8203     8200       -3     
- Misses       4761     4769       +8     
  Partials     1002     1002

@jim jim self-requested a review Jun 4, 2019

@jim

jim approved these changes Jun 4, 2019

Copy link
Contributor

left a comment

🚢

@chrisgilmerproj chrisgilmerproj merged commit b2afb0d into master Jun 4, 2019

18 of 19 checks passed

codecov/project/go 58.5% (-0.04%) compared to 3a48880
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 3a48880...11886d3
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_remove_unneeded_tool_targets branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.