Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable Spellcheck Pre-Commit Hook #2223

Merged
merged 5 commits into from Jun 6, 2019

Conversation

@Igarfinkle
Copy link
Contributor

commented Jun 3, 2019

Description

Cleans up some issues with the spellcheck precommit hook. Makes interactive spellchecker run on same files as precommit hook does.

Reviewer Notes

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

@Igarfinkle Igarfinkle requested review from jim, Ryan-Koch and pjdufour-truss Jun 3, 2019

Igarfinkle added some commits Jun 5, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #2223 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2223      +/-   ##
==========================================
- Coverage      59%   58.97%   -0.03%     
==========================================
  Files         250      250              
  Lines       14085    14075      -10     
==========================================
- Hits         8310     8300      -10     
  Misses       4774     4774              
  Partials     1001     1001

@Igarfinkle Igarfinkle requested a review from chrisgilmerproj Jun 6, 2019

@chrisgilmerproj
Copy link
Contributor

left a comment

🚀

@Igarfinkle Igarfinkle merged commit ba498bd into master Jun 6, 2019

18 of 19 checks passed

codecov/project/go 58.79% (-0.03%) compared to f9ea888
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing f9ea888...0155bbe
Details

@Igarfinkle Igarfinkle deleted the ig-165796993-reenable-spellcheck-hook branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.