Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the path for 'aws' binary #2226

Merged
merged 1 commit into from Jun 4, 2019

Conversation

3 participants
@chrisgilmerproj
Copy link
Contributor

commented Jun 4, 2019

Description

The path changed for aws and this ought to point it at the right place.

@Igarfinkle
Copy link
Contributor

left a comment

Beautiful!

@lynzt

lynzt approved these changes Jun 4, 2019

Copy link
Contributor

left a comment

🚢

@codecov

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #2226 into master will decrease coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2226      +/-   ##
==========================================
- Coverage   59.01%   58.75%   -0.26%     
==========================================
  Files         251      246       -5     
  Lines       14072    13968     -104     
==========================================
- Hits         8304     8206      -98     
+ Misses       4767     4761       -6     
  Partials     1001     1001

@chrisgilmerproj chrisgilmerproj merged commit 00905e3 into master Jun 4, 2019

18 of 19 checks passed

codecov/project/go 58.56% (-0.27%) compared to da8c563
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing da8c563...45b3f64
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_change_aws_path branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.