Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment variable quoting which disrupts the way the array is formed in the script #2232

Merged

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

commented Jun 5, 2019

Description

shellcheck asked that the variable be quoted. However, doing so means that it doesn't turn into an array, which is what's needed to run the script.

@chrisgilmerproj chrisgilmerproj requested review from jim and Igarfinkle Jun 5, 2019

@jim

jim approved these changes Jun 5, 2019

Copy link
Contributor

left a comment

:shipit:

@chrisgilmerproj chrisgilmerproj merged commit 5916467 into master Jun 5, 2019

17 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
@codecov

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #2232 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2232      +/-   ##
==========================================
+ Coverage   58.99%   59.02%   +0.03%     
==========================================
  Files         250      251       +1     
  Lines       14066    14078      +12     
==========================================
+ Hits         8298     8309      +11     
  Misses       4767     4767              
- Partials     1001     1002       +1

@chrisgilmerproj chrisgilmerproj deleted the cg_fix_secure_migration_scripts_environment_var branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.