Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove links to DDS GDrive from .envrc file #2233

Merged
merged 1 commit into from Jun 5, 2019

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

commented Jun 5, 2019

Description

Truss migrated all the docs from DDS GDrive to a Truss owned shared GDrive. Also, since we started using chamber the docs are no longer the source of truth for these secrets. In addition, we shouldn't share secrets via google docs.

All of these documents are now View Only on the DDS GDrive and they have been deleted from the Truss shared GDrive.

Setup

direnv allow

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

Remove links to DDS GDrive from .envrc file as they are no longer the…
… source of truth and because we shouldn't share secrets via google docs
@codecov

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #2233 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2233      +/-   ##
==========================================
- Coverage   59.05%   58.99%   -0.05%     
==========================================
  Files         251      250       -1     
  Lines       14084    14069      -15     
==========================================
- Hits         8316     8300      -16     
  Misses       4767     4767              
- Partials     1001     1002       +1

@chrisgilmerproj chrisgilmerproj merged commit 8b896ba into master Jun 5, 2019

18 of 19 checks passed

codecov/project/go 58.81% (-0.05%) compared to 5916467
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 5916467...79733be
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_166477704_remove_gdoc_from_envrc branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.